AP's color theme sometimes makes text unreadable  

This forum is dedicated to Autopano Pro / Giga bug reports and features discussion.
Please read the posting rules before starting a topic!
User avatar
DrSlony
Moderator
 
Topic author
Posts: 1893
Likes: 0 post
Liked in: 0 post
Joined: Sat Nov 03, 2007 6:30 pm
Location: Sweden
Info

AP's color theme sometimes makes text unreadable

by DrSlony » Fri Sep 16, 2011 10:14 pm

It can happen that the font color used in AP it so similar to a background color that it's unreadable.

Image Image

User avatar
DrSlony
Moderator
 
Topic author
Posts: 1893
Likes: 0 post
Liked in: 0 post
Joined: Sat Nov 03, 2007 6:30 pm
Location: Sweden
Info

by DrSlony » Fri Sep 16, 2011 10:15 pm

APG-2.5.2 in KDE4.

User avatar
DrSlony
Moderator
 
Topic author
Posts: 1893
Likes: 0 post
Liked in: 0 post
Joined: Sat Nov 03, 2007 6:30 pm
Location: Sweden
Info

by DrSlony » Fri Sep 16, 2011 10:23 pm

You probably missed this bug because your system color theme uses black as your font color. Change it to something else, e.g. red, and you will see the problem on your own machines.

User avatar
gkaefer
Member
 
Posts: 3549
Likes: 0 post
Liked in: 15 posts
Joined: Tue Jun 09, 2009 1:01 pm
Location: Salzburg
Info

by gkaefer » Fri Sep 16, 2011 11:07 pm

APG 2.6.0 beta 2 seems to be solved...
(win7 64bit)

Georg


Last edited by gkaefer on Fri Sep 16, 2011 11:08 pm, edited 1 time in total.

User avatar
DrSlony
Moderator
 
Topic author
Posts: 1893
Likes: 0 post
Liked in: 0 post
Joined: Sat Nov 03, 2007 6:30 pm
Location: Sweden
Info

by DrSlony » Sat Sep 17, 2011 9:21 pm

Try setting your Windows font color to red and then see.

User avatar
gkaefer
Member
 
Posts: 3549
Likes: 0 post
Liked in: 15 posts
Joined: Tue Jun 09, 2009 1:01 pm
Location: Salzburg
Info

by gkaefer » Sat Sep 17, 2011 9:27 pm

? sorry dont get the point ?
Why should I config my windows desktop to nonstandard to see how APG than looks like?
why cant you change your font color to black?
Georg
Last edited by gkaefer on Sat Sep 17, 2011 9:29 pm, edited 1 time in total.

User avatar
DrSlony
Moderator
 
Topic author
Posts: 1893
Likes: 0 post
Liked in: 0 post
Joined: Sat Nov 03, 2007 6:30 pm
Location: Sweden
Info

by DrSlony » Sat Sep 17, 2011 10:43 pm

Because you're commenting on a bug dependent on the operating system/desktop environment using a font color that is not black.

User avatar
gkaefer
Member
 
Posts: 3549
Likes: 0 post
Liked in: 15 posts
Joined: Tue Jun 09, 2009 1:01 pm
Location: Salzburg
Info

by gkaefer » Sun Sep 18, 2011 12:39 am

KDE 4.? which OS?
which color cheme did you set? (default in KDE is black/white)

Georg

User avatar
DrSlony
Moderator
 
Topic author
Posts: 1893
Likes: 0 post
Liked in: 0 post
Joined: Sat Nov 03, 2007 6:30 pm
Location: Sweden
Info

by DrSlony » Mon Sep 19, 2011 2:28 am

To trigger the problem in Linux:
1- Fire up "qtconfig > Tune Palette" and set "Text" to #FF0000 (as in the attached screenshot). Apply the settings.
If you're using KDE4 then your qtconfig won't have a "Tune Palette" button. Instead, fire up "System Settings > Application Appearance > Colors > Colors" and set "View Text" to #FF0000. Apply the settings.
2- Fire up AutopanoGiga.sh and observe how some elements did not have their colors applied by APG; instead, they get their colors from the QT theme your system uses.

The above describes how to trigger this bug step by step in Linux, but it pertains to all operating systems/desktop environments!



User avatar
DrSlony
Moderator
 
Topic author
Posts: 1893
Likes: 0 post
Liked in: 0 post
Joined: Sat Nov 03, 2007 6:30 pm
Location: Sweden
Info

by DrSlony » Mon Sep 19, 2011 3:09 am

Since the whole AP interface is themed by AP and not by the operating system/window manager (except for the elements that were overlooked, which this bug report is about), and since the background of the un-styled text is always light (in both dark and light AP themes), it makes sense to set all text to black in the base QT stylesheet, and then have other entries in the stylesheet change the text color of specific elements as needed, e.g. text on dark background should not be black but light.

The fix is simple:
Code: Select all
diff -Naurd Resources/UI/style_sheet_2.qss Resources/UI/style_sheet_2.qss
--- Resources/UI/style_sheet_2.qss       2011-09-19 03:03:29.980970137 +0100
+++ Resources/UI/style_sheet_2.qss      2011-09-19 03:03:19.565970144 +0100
@@ -1,3 +1,4 @@
+QWidget { color: black }
 
 /*----------------------------------------------------------------------------*/
 /*----------------------------------------------------------------------------*/
diff -Naurd Resources/UI/style_sheet.qss Resources/UI/style_sheet.qss
--- Resources/UI/style_sheet.qss 2011-09-19 03:03:29.981970137 +0100
+++ Resources/UI/style_sheet.qss        2011-09-19 03:03:19.566970144 +0100
@@ -1,3 +1,4 @@
+QWidget { color: black }
 
 /*----------------------------------------------------------------------------*/
 /*----------------------------------------------------------------------------*/

Of course, these few un-styled elements should also be styled in the source files of AP.

The first screenshot shows the problem when your operating system/desktop environment/qtconfig uses a non-black font color (red in this example, to highlight the problem), and the second screenshot shows how that non-black font color stops being a problem when you apply the above patch.





User avatar
DrSlony
Moderator
 
Topic author
Posts: 1893
Likes: 0 post
Liked in: 0 post
Joined: Sat Nov 03, 2007 6:30 pm
Location: Sweden
Info

by DrSlony » Thu Oct 13, 2011 11:53 pm

AutopanoGiga-2.6-beta4 suffers from the same problem of some elements having no font color set which results in them inheriting a color from the system, which ends up unreadable. The solution proposed above fixes the issues.

Below are before and after screenshots:






Who is online

Users browsing this forum: No registered users and 3 guests